Skip to content

Remove legacy configuration options#752

Merged
esune merged 2 commits intomainfrom
feature/removeLegacyParams
Apr 4, 2025
Merged

Remove legacy configuration options#752
esune merged 2 commits intomainfrom
feature/removeLegacyParams

Conversation

@loneil
Copy link
Contributor

@loneil loneil commented Apr 3, 2025

useOobPresentProof - specified whether to use out of band, we can use that for everything now

useUrlDeepLink - was put in when we needed to feature toggle ?_url on and off for testing

Clean up code that used these configuration values and remove them

@loneil loneil force-pushed the feature/removeLegacyParams branch from cc2c197 to afdcd00 Compare April 3, 2025 23:43
@coveralls
Copy link

coveralls commented Apr 3, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14258425399

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.6%) to 87.841%
Totals Coverage Status
Change from base Build 14256673081: 2.6%
Covered Lines: 708
Relevant Lines: 806
💛 - Coveralls

esune
esune reviewed Apr 4, 2025
View reviewed changes
Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo, otherwise it's looking good.
Not really sure about why the code coverage would drop that significantly since tests were not removed - it all seems to be in /oidc-controller/api/core/config.py in a utility function used to evaluate booleans.

@loneil
Remove OOB and URL config options
2053c33 
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
@loneil loneil force-pushed the feature/removeLegacyParams branch from 5b1ce5c to 15d1e24 Compare April 4, 2025 05:02
@loneil
Add a unit test
e6f66c2 
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
@loneil loneil force-pushed the feature/removeLegacyParams branch from fc96130 to e6f66c2 Compare April 4, 2025 05:06
@loneil
Copy link
Contributor Author

loneil commented Apr 4, 2025

@esune I left in the USE_OOB_LOCAL_DID_SERVICE stuff, is that something we want to keep?

Small typo, otherwise it's looking good. Not really sure about why the code coverage would drop that significantly since tests were not removed - it all seems to be in /oidc-controller/api/core/config.py in a utility function used to evaluate booleans.

Yeah not sure why it counted a drop in coverage? Only 0.04% but I did not alter that code path... added a bit of coverage anyways, added a test for generating the proofs I noticed was lacking too.

@loneil loneil requested a review from esune April 4, 2025 05:10
@loneil loneil mentioned this pull request Apr 4, 2025
Closed
@esune esune merged commit b237703 into main Apr 4, 2025
6 checks passed
@esune esune deleted the feature/removeLegacyParams branch April 4, 2025 23:39
@loneil loneil mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esune esune esune approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@loneil @coveralls @esune